Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace helm v2 dependency with helm v3 #444

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Replace helm v2 dependency with helm v3 #444

merged 1 commit into from
Mar 29, 2023

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind technical-debt

What this PR does / why we need it:
testrunner has a dependency to the go modules of helm v2. It is used to render helm-style TestRun charts.

This PR replaces helm v2 with helm v3 (latest & greatest).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

Release note:

`testrunner` uses helm v3 modules to render testrun charts.

@hendrikKahl hendrikKahl requested a review from a team as a code owner March 28, 2023 14:44
@gardener-robot gardener-robot added area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Mar 28, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 28, 2023
dguendisch
dguendisch approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 28, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 28, 2023
@hendrikKahl hendrikKahl merged commit f4d2e99 into gardener:master Mar 29, 2023
@hendrikKahl hendrikKahl deleted the dep-update-helm3 branch March 29, 2023 08:39
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hendrikKahl @dguendisch @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot