Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context metadata to testruns executed by the testrunner #40

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Add context metadata to testruns executed by the testrunner #40

merged 1 commit into from
Mar 26, 2019

Conversation

schrodit
Copy link

What this PR does / why we need it:
This PR adds a new type called Run which represents a testrun with specific metadata.
This makes it possible to have specific metadata information like the k8s version, for a testrun executed by the testrunner.

Special notes for your reviewer:

Release note:

Add context metadata to testruns executed by the Testrunner.

@schrodit schrodit force-pushed the fix/kubernetes-version-for-multiple-testruns branch 2 times, most recently from 7bf9df0 to 314d942 Compare March 25, 2019 11:06
@schrodit schrodit marked this pull request as ready for review March 25, 2019 11:06
@schrodit schrodit requested a review from a team as a code owner March 25, 2019 11:06
@schrodit schrodit added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 25, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 25, 2019
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 25, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 25, 2019
@schrodit schrodit force-pushed the fix/kubernetes-version-for-multiple-testruns branch from 314d942 to a1a685f Compare March 25, 2019 14:15
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 25, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 25, 2019
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 25, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 26, 2019
@schrodit schrodit force-pushed the fix/kubernetes-version-for-multiple-testruns branch from a1a685f to 6ebb914 Compare March 26, 2019 07:16
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 26, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 26, 2019
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 26, 2019
@schrodit schrodit force-pushed the fix/kubernetes-version-for-multiple-testruns branch from 6ebb914 to e03fb93 Compare March 26, 2019 08:54
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 26, 2019
@schrodit schrodit merged commit 890ee38 into gardener:master Mar 26, 2019
@schrodit schrodit deleted the fix/kubernetes-version-for-multiple-testruns branch March 26, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schrodit @dguendisch @gardener-robot-ci-1