Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use workflow namespace for pod garbage collection #397

Merged
merged 2 commits into from
Mar 9, 2022
Merged

use workflow namespace for pod garbage collection #397

merged 2 commits into from
Mar 9, 2022

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
The testmachinery controller implements some basic garbage collection to clean-up pods related to completed workflows. Even though the controller deploys workflows into different namespaces, it tries to find any pod in its own namespace.

This PR changes the behavior to look into the namespace of the actual workflow for garbage collectoin.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/invite @dguendisch

Release note:

Fix pod garbage collection when using multiple namespaces

@hendrikKahl hendrikKahl requested a review from a team as a code owner March 9, 2022 07:15
@gardener-robot gardener-robot added the needs/review Needs review label Mar 9, 2022
@gardener-robot gardener-robot added area/testing Testing related kind/bug Bug size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 9, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 9, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 9, 2022
dguendisch
dguendisch approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 9, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 9, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 9, 2022
@hendrikKahl hendrikKahl merged commit 1e286f2 into gardener:master Mar 9, 2022
@hendrikKahl hendrikKahl deleted the fix-pod-deletion branch March 9, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hendrikKahl @dguendisch @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot