Add argoui link to metadata output #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schrodit
force-pushed
the
add-argoui-link
branch
from
9bcaa7e to
92ec246
Compare
dguendisch
requested changes
Mar 19, 2019
schrodit
added
the
reviewed/ok-to-test
gardener-robot-ci-1
added
needs/ok-to-test
OlegLoewen
reviewed
Mar 19, 2019
schrodit
force-pushed
the
add-argoui-link
branch
from
de19254 to
f334acf
Compare
Co-Authored-By: schrodit <tschrodi96@googlemail.com>
schrodit
force-pushed
the
add-argoui-link
branch
from
f334acf to
4d4adb0
Compare
dguendisch
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds another optional metadata field which is a link that points to the wf in an argo ui.
Therefore another flag
argoui-endpointis introduced where the argoui endpoint can be specified which is then used to generate the URL for the specific workflow.Special notes for your reviewer:
Release note: