Fix lost image pull secret handling #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
dguendisch
force-pushed
the
image-pull-secrets
branch
from
c09eca0 to
c31fae6
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
dguendisch
force-pushed
the
image-pull-secrets
branch
from
c31fae6 to
ae8b125
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
dguendisch
force-pushed
the
image-pull-secrets
branch
from
ae8b125 to
42c4a37
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
added
size/xl
dguendisch
force-pushed
the
image-pull-secrets
branch
from
42c4a37 to
9f9cfe6
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
I verified on our staging instance that imagepullsecrets are now correctly applied to resulting workflow pods. |
gardener-robot
added
reviewed/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
work-in-progress
Image Pull Secret handling broke when we moved testmachinery config generation.
This PR re-adds the option to specify image pull secrets via
charts/testmachinery/values.yaml.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: