Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test case 301 to case 400 - Jc #344

Merged
merged 1 commit into from
May 12, 2021
Merged

Test case 301 to case 400 - Jc #344

merged 1 commit into from
May 12, 2021

Conversation

jguipi
Copy link
Contributor

@jguipi jguipi commented May 5, 2021

What this PR does / why we need it:
These test cases have been validated success against aws/gcp/azure on k8s 1.20.4, hence moving it from skip.json to working.json
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@jguipi jguipi requested a review from a team as a code owner May 5, 2021 14:31
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 5, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 5, 2021
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label May 5, 2021
@gardener-robot
Copy link

@jguipi You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 5, 2021
schrodit
schrodit suggested changes May 6, 2021
View reviewed changes
Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test cases have been validated success against aws/gcp/azure on k8s 1.20.4, hence moving it from skip.json to working.json
I think you missed to add the testcases in the working.json?
They are just removed from the skip.json.

When you add the testcases can you also check their execution times and categorize them respectively (tests that are faster than 2minutes belong to the fast group all others to the slow group)

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label May 6, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 6, 2021
@jguipi
Copy link
Contributor Author

jguipi commented May 6, 2021

These test cases have been validated success against aws/gcp/azure on k8s 1.20.4, hence moving it from skip.json to working.json
I think you missed to add the testcases in the working.json?
They are just removed from the skip.json.

When you add the testcases can you also check their execution times and categorize them respectively (tests that are faster than 2minutes belong to the fast group all others to the slow group)

Done :) !

@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 6, 2021
@dguendisch
Copy link
Member

Hi @jguipi , are you sure that we go down from ~434 tests in working.json vs now some 34 ones?

@gardener-robot gardener-robot removed the needs/rebase Needs git rebase label May 7, 2021
@jguipi
new entries
4bcd1ba 
filtering test case

adding groups
@jguipi jguipi changed the title Jc test Test case 301 to case 400 - Jc May 11, 2021
@gardener-robot gardener-robot added size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) and removed size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) labels May 11, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 11, 2021
@jguipi
Copy link
Contributor Author

jguipi commented May 11, 2021 •
edited
Loading

Hi @jguipi , are you sure that we go down from ~434 tests in working.json vs now some 34 ones?

Was missing the data from the upstream. IJust merge and rebase it all

dguendisch
dguendisch approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels May 12, 2021
@schrodit schrodit merged commit eb85a12 into gardener:master May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

@schrodit schrodit schrodit approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jguipi @gardener-robot @dguendisch @schrodit @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3