Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support telemetry controller #145

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Add support telemetry controller #145

merged 1 commit into from
Sep 13, 2019

Conversation

schrodit
Copy link

@schrodit schrodit commented Sep 12, 2019 •
edited
Loading

What this PR does / why we need it:
Adds the internal gardener-shoot-telemetry project into the test-infra project

Originally authored by @dkistner

Special notes for your reviewer:

We also need to discuss codeowner ship.

Release note:

Add telemetry-controller to test-infra

@schrodit schrodit added area/monitoring Monitoring (including availability monitoring and alerting) related reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies labels Sep 12, 2019
@schrodit schrodit requested a review from a team as a code owner September 12, 2019 11:17
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 12, 2019
@schrodit schrodit force-pushed the telemetry-controller branch from cc02690 to da3ea9e Compare September 12, 2019 11:34
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 12, 2019
@schrodit schrodit force-pushed the telemetry-controller branch from da3ea9e to eab2db7 Compare September 12, 2019 11:45
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 12, 2019
@schrodit schrodit force-pushed the telemetry-controller branch from eab2db7 to 894bafe Compare September 12, 2019 12:02
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 12, 2019
@schrodit
Copy link
Author

code ownership will be taken by the test-infra maintainers as discussed offline.

@schrodit schrodit merged commit 68d9eb7 into gardener:master Sep 13, 2019
@schrodit schrodit deleted the telemetry-controller branch September 13, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

@RaphaelVogel RaphaelVogel Awaiting requested review from RaphaelVogel

@dkistner dkistner Awaiting requested review from dkistner

Assignees
No one assigned
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schrodit @dguendisch @gardener-robot-ci-1