Don't update machine status to terminating on deletion failure #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@takoverflow Thank you for your contribution. |
gardener-robot
added
needs/review
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
ghost
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
aaronfern
reviewed
May 21, 2025
Member
aaronfern
left a comment
aaronfern
left a comment
There was a problem hiding this comment.
Thanks for the PR!
The release note looks a bit vague, can you please relook at it?
Consider something like (does not need to be this, please add what you feel is appropriate)
Fixed a bug in the MachineSet controller where the machine status was set to `Terminating` even if attempt to delete the machine object failed.
elankath
approved these changes
May 27, 2025
Member
elankath
left a comment
elankath
left a comment
There was a problem hiding this comment.
thanks - this was a gap in the current code that caused stuck in Terminating phase esp when VM's could not be launched for some cases.
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upon failure in deletion of a machine, it should not transition to
Terminatingphase.Which issue(s) this PR fixes:
Fixes #984
Special notes for your reviewer:
Release note: