[Edge Case] Creation/Health Timeout not respected

[himanshu-kun]

How to categorize this issue?

/area quality
/kind bug
/priority 3

What happened:
The creationTimeout / healthTimeout is not respected in the following cases , as per code analysis :

Case 1:

• machine obj = Pending , Node = NotReady , node conditions changed
  • Result : timeout not checked in this reconcile
  • if node conditions keep on changing , then timeout never checked

Case 2:

• machine obj = Pending , Node = Ready, node.gardener.cloud/critical-components-not-ready taint present on node, node conditions changed
  • Result : timeout not checked
  • if node conditions keep on changing , then timeout never checked

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version):
• Cloud provider or hardware configuration:
• Others:
  any mcm provider vendoring mcm <= v0.49.0

[himanshu-kun]

Post grooming issue

If node conditions keep flapping , then cloneDirty will become true in every reconcile, so timeout checking is always skipped.

should be dealt in controller runtime refactor.

[himanshu-kun]

Post grooming issue

If node conditions keep flapping , then cloneDirty will become true in every reconcile, so timeout checking is always skipped.

should be dealt in controller runtime refactor.