Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metrics support #110

Merged
merged 1 commit into from
Feb 11, 2021
Merged

add metrics support #110

merged 1 commit into from
Feb 11, 2021

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area monitoring
/kind enhancement
/priority normal

What this PR does / why we need it:
Expose default metrics collected by the controller-runtime for landscaper-controller to gain more insights and enable basic monitoring.
Additionally metrics for the oci cache(s) are registered and collected.

The landscaper config & helm chart have been extended to make the metrics port configurable.

Which issue(s) this PR fixes:
partially fixes #48

Special notes for your reviewer:

Release note:

Expose controller-runtime metrics for landscaper-controller and add oci cache metrics.

@hendrikKahl hendrikKahl requested a review from a team as a code owner February 5, 2021 10:59
@gardener-robot gardener-robot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension priority/normal needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Feb 5, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 5, 2021
schrodit
schrodit reviewed Feb 9, 2021
View reviewed changes
Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also vendor the new component-cli v0.10.0 and include the new configuration.
Rest is lgtm

apis/config/types_landscaper_config.go Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 9, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 9, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 9, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 9, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 9, 2021
@schrodit
Copy link

wait until we have discussed the pattern
/hold

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Feb 10, 2021
@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Feb 11, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 11, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 11, 2021
schrodit
schrodit reviewed Feb 11, 2021
View reviewed changes
Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small note rest is lgtm

pkg/landscaper/controllers/installations/actuator.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 11, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 11, 2021
schrodit
schrodit approved these changes Feb 11, 2021
View reviewed changes
Copy link

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Feb 11, 2021
@hendrikKahl hendrikKahl merged commit 1f03ba4 into gardener:master Feb 11, 2021
@hendrikKahl hendrikKahl deleted the metrics branch February 11, 2021 14:44
@hendrikKahl hendrikKahl mentioned this pull request Feb 12, 2021
Closed
6 tasks
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schrodit schrodit schrodit approved these changes

Assignees
No one assigned
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies reviewed/lgtm Has approval for merging size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

☂️ Monitoring
6 participants
@hendrikKahl @schrodit @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot