-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add metrics support #110
add metrics support #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also vendor the new component-cli v0.10.0 and include the new configuration.
Rest is lgtm
wait until we have discussed the pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small note rest is lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area monitoring
/kind enhancement
/priority normal
What this PR does / why we need it:
Expose default metrics collected by the controller-runtime for
landscaper-controller
to gain more insights and enable basic monitoring.Additionally metrics for the oci cache(s) are registered and collected.
The landscaper config & helm chart have been extended to make the metrics port configurable.
Which issue(s) this PR fixes:
partially fixes #48
Special notes for your reviewer:
Release note: