Change dnsLookupFamily to ALL in vpn seed envoy config. #9102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/networking
gardener-prow
bot
added
cla: yes
axel7born
force-pushed
the
vpn-envoy-dnslookup
branch
from
bf1c55e
to
3327793
Compare
ScheererJ
approved these changes
Feb 1, 2024
|
LGTM label has been added. Git tree hash: 0146cdf4f85baf01c57fb1b151252703ee99aca5
|
gardener-prow
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DockToFuture, ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind enhancement
What this PR does / why we need it:
The envoy property
dnsLookupFamilydetermines the address family for DNS lookups.V4_PREFEREDmeans, that a DNS lookup for the IPv4 address is made and if there is no result a lookup for IPv6 is made.The meaning of
ALLwould be that both IPv4 and IPv6 lookups are made.However, the property has the side effect, that with
IPV4_PREFEREDenvoy tries to resolve IPv6 addresses as hostnames.This results in unnecessary DNS queries.
The envoy proxy in the VPN seed server doesn't need to to do any DNS lookups. Unnecessary lookups for addresses as hostnames can prevented by setting dnsLookupFamily to
ALL.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: