-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change dnsLookupFamily to ALL in vpn seed envoy config. #9102
Conversation
bf1c55e
to
3327793
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the nice improvement to reduce the DNS load in IPv6 scenarios.
/lgtm
/approve
LGTM label has been added. Git tree hash: 0146cdf4f85baf01c57fb1b151252703ee99aca5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DockToFuture, ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area networking
/kind enhancement
What this PR does / why we need it:
The envoy property
dnsLookupFamily
determines the address family for DNS lookups.V4_PREFERED
means, that a DNS lookup for the IPv4 address is made and if there is no result a lookup for IPv6 is made.The meaning of
ALL
would be that both IPv4 and IPv6 lookups are made.However, the property has the side effect, that with
IPV4_PREFERED
envoy tries to resolve IPv6 addresses as hostnames.This results in unnecessary DNS queries.
The envoy proxy in the VPN seed server doesn't need to to do any DNS lookups. Unnecessary lookups for addresses as hostnames can prevented by setting dnsLookupFamily to
ALL
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: