Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log a minor retriable error as info instead of an error #8746

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Log a minor retriable error as info instead of an error #8746

merged 2 commits into from
Nov 15, 2023

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Nov 1, 2023 •
edited
Loading

How to categorize this PR?

/area quality
/kind enhancement

What this PR does / why we need it:
There is an transient error that gets logged as an actual error. We will just log it as info

Which issue(s) this PR fixes:
Fixes: #8148

Release note:

NONE

@gardener-prow gardener-prow bot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2023
@Kostov6
Copy link
Contributor Author

Kostov6 commented Nov 1, 2023

/retest

2 similar comments
@Kostov6
Copy link
Contributor Author

Kostov6 commented Nov 1, 2023

/retest

@Kostov6
Copy link
Contributor Author

Kostov6 commented Nov 2, 2023

/retest

@Kostov6 @rfranzke
Use description instead of details in log message
6976809 
Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
rfranzke
rfranzke reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 15, 2023

LGTM label has been added.

Git tree hash: 533e8d1680a657568cdf5d5dc802a232de3ccb44

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@gardener-prow gardener-prow bot merged commit dc2cf26 into gardener:master Nov 15, 2023
16 checks passed
@Kostov6 Kostov6 deleted the dont-log-minor-errors branch May 21, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@timuthy timuthy Awaiting requested review from timuthy

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't log minor retriable errors as errors
2 participants
@Kostov6 @rfranzke