Fix network policy in local setup in conjunction with HA VPN. #8370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the network policy specifying the allowed traffic to the machine pods in the local setup only listed other machine pods and `vpn-seed-server` as allowed ingress sources. However, in the HA VPN case `kube-apiserver` connects to machines as well. The connection to kubelet was allowed, but everything else was blocked by policy. This meant that `kubectl proxy` would not allow proxying traffic to pods in the host network due to network policy. This change adapts the network policy to work in both VPN cases and use the more general `to-shoot-networks` labels, which were already used correctly.
gardener-prow
bot
added
area/networking
|
Issues reaching github.com in tests: |
|
LGTM label has been added. Git tree hash: 87ca83273624d56dc2c0f22863f72126fea1a92a
|
acumino
approved these changes
Aug 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
Test cluster should be fixed now. |
briantopping
pushed a commit
to briantopping/gardener
that referenced
this pull request
Aug 22, 2023
…er#8370) Previously, the network policy specifying the allowed traffic to the machine pods in the local setup only listed other machine pods and `vpn-seed-server` as allowed ingress sources. However, in the HA VPN case `kube-apiserver` connects to machines as well. The connection to kubelet was allowed, but everything else was blocked by policy. This meant that `kubectl proxy` would not allow proxying traffic to pods in the host network due to network policy. This change adapts the network policy to work in both VPN cases and use the more general `to-shoot-networks` labels, which were already used correctly.
nickytd
pushed a commit
to nickytd/gardener
that referenced
this pull request
Sep 11, 2023
…er#8370) Previously, the network policy specifying the allowed traffic to the machine pods in the local setup only listed other machine pods and `vpn-seed-server` as allowed ingress sources. However, in the HA VPN case `kube-apiserver` connects to machines as well. The connection to kubelet was allowed, but everything else was blocked by policy. This meant that `kubectl proxy` would not allow proxying traffic to pods in the host network due to network policy. This change adapts the network policy to work in both VPN cases and use the more general `to-shoot-networks` labels, which were already used correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/area dev-productivity
/kind bug
What this PR does / why we need it:
Fix network policy in local setup in conjunction with HA VPN.
Previously, the network policy specifying the allowed traffic to the machine pods in the local setup only listed other machine pods and
vpn-seed-serveras allowed ingress sources. However, in the HA VPN casekube-apiserverconnects to machines as well. The connection to kubelet was allowed, but everything else was blocked by policy. This meant thatkubectl proxywould not allow proxying traffic to pods in the host network due to network policy. This change adapts the network policy to work in both VPN cases and use the more generalto-shoot-networkslabels, which were already used correctly.Which issue(s) this PR fixes:
None.
Special notes for your reviewer:
Release note:
/cc @istvanballok @MartinWeindel