[GEP-22] Drop shootstate-extensions and shootstate-secret controllers
#8136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, we now fetch the `ShootState` object in the restore phase only (this is the only phase when we need it) and store it directly on the internal `Shoot` object.
Only if the gardenlet is responsible for an unmanaged `Seed` - otherwise, its `shoot-state` reconciler wants to perform regular backups of the `ShootState`, so we shouldn't delete it even after successful restoration.
From gardener#8112 (comment): > In our e2e tests the cpm test shoots are always scheduled on a non-managed seed. With this, the controller would always be active and we wouldn't verify that migration also works without periodic backups. Since we don't need this periodic backup functionality in e2e tests, we simply disable the controller.
gardener-prow
bot
added
area/scalability
7 tasks
gardener-prow
bot
added
cla: yes
timebertt
reviewed
Jun 22, 2023
|
LGTM label has been added. Git tree hash: 4138afa7eba00e5ba07fb6ee1e391f0d684bb689
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
|
@rfranzke: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
andrerun
pushed a commit
to andrerun/gardener
that referenced
this pull request
Jul 6, 2023
…lers (gardener#8136) * Drop legacy `ShootState` controllers * Remove legacy ShootState controller finalizer from secrets * Drop {Get,Set}ShootState methods on `Botanist` * Drop `EnsureShootStateExists` function Instead, we now fetch the `ShootState` object in the restore phase only (this is the only phase when we need it) and store it directly on the internal `Shoot` object. * Delete `ShootState` after restoration Only if the gardenlet is responsible for an unmanaged `Seed` - otherwise, its `shoot-state` reconciler wants to perform regular backups of the `ShootState`, so we shouldn't delete it even after successful restoration. * Disable `shoot-state` reconciler locally From gardener#8112 (comment): > In our e2e tests the cpm test shoots are always scheduled on a non-managed seed. With this, the controller would always be active and we wouldn't verify that migration also works without periodic backups. Since we don't need this periodic backup functionality in e2e tests, we simply disable the controller.
nickytd
pushed a commit
to nickytd/gardener
that referenced
this pull request
Sep 11, 2023
…lers (gardener#8136) * Drop legacy `ShootState` controllers * Remove legacy ShootState controller finalizer from secrets * Drop {Get,Set}ShootState methods on `Botanist` * Drop `EnsureShootStateExists` function Instead, we now fetch the `ShootState` object in the restore phase only (this is the only phase when we need it) and store it directly on the internal `Shoot` object. * Delete `ShootState` after restoration Only if the gardenlet is responsible for an unmanaged `Seed` - otherwise, its `shoot-state` reconciler wants to perform regular backups of the `ShootState`, so we shouldn't delete it even after successful restoration. * Disable `shoot-state` reconciler locally From gardener#8112 (comment): > In our e2e tests the cpm test shoots are always scheduled on a non-managed seed. With this, the controller would always be active and we wouldn't verify that migration also works without periodic backups. Since we don't need this periodic backup functionality in e2e tests, we simply disable the controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area scalability
/kind enhancement
What this PR does / why we need it:
This PR drops the legacy
shootstate-extensionsandshootstate-secretcontrollers.It also changes the
Shootflows such thatShootStateexistence is no longer ensured at the beginning (after [GEP-22] Change control plane migration flow to fetch relevant shoot state ad-hoc and push it to theShootStateresource #8082, it gets created only on demand as part of the migration flow)ShootStateis deleted at the end of a successful restoration (only ifgardenletis not running the newShootStatecontroller introduced with [GEP-22] Perform regular state backups forShoots running on unmanagedSeeds #8112)Additionally, as suggested in #8112 (comment), the new
ShootStatecontroller introduced with #8112 is disabled locally since it's not needed here and would only distort the e2e test results.Which issue(s) this PR fixes:
Part of #8073
Special notes for your reviewer:
The next step in the implementation of GEP-22 is cleaning up still existing
ShootStates forShoots running onManagedSeeds./cc @timebertt
Release note: