-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEP-22] Drop shootstate-extensions
and shootstate-secret
controllers
#8136
[GEP-22] Drop shootstate-extensions
and shootstate-secret
controllers
#8136
Conversation
Instead, we now fetch the `ShootState` object in the restore phase only (this is the only phase when we need it) and store it directly on the internal `Shoot` object.
Only if the gardenlet is responsible for an unmanaged `Seed` - otherwise, its `shoot-state` reconciler wants to perform regular backups of the `ShootState`, so we shouldn't delete it even after successful restoration.
From gardener#8112 (comment): > In our e2e tests the cpm test shoots are always scheduled on a non-managed seed. With this, the controller would always be active and we wouldn't verify that migration also works without periodic backups. Since we don't need this periodic backup functionality in e2e tests, we simply disable the controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, I don't have any suggestions :)
/lgtm
/approve
LGTM label has been added. Git tree hash: 4138afa7eba00e5ba07fb6ee1e391f0d684bb689
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timebertt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rfranzke: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…lers (gardener#8136) * Drop legacy `ShootState` controllers * Remove legacy ShootState controller finalizer from secrets * Drop {Get,Set}ShootState methods on `Botanist` * Drop `EnsureShootStateExists` function Instead, we now fetch the `ShootState` object in the restore phase only (this is the only phase when we need it) and store it directly on the internal `Shoot` object. * Delete `ShootState` after restoration Only if the gardenlet is responsible for an unmanaged `Seed` - otherwise, its `shoot-state` reconciler wants to perform regular backups of the `ShootState`, so we shouldn't delete it even after successful restoration. * Disable `shoot-state` reconciler locally From gardener#8112 (comment): > In our e2e tests the cpm test shoots are always scheduled on a non-managed seed. With this, the controller would always be active and we wouldn't verify that migration also works without periodic backups. Since we don't need this periodic backup functionality in e2e tests, we simply disable the controller.
…lers (gardener#8136) * Drop legacy `ShootState` controllers * Remove legacy ShootState controller finalizer from secrets * Drop {Get,Set}ShootState methods on `Botanist` * Drop `EnsureShootStateExists` function Instead, we now fetch the `ShootState` object in the restore phase only (this is the only phase when we need it) and store it directly on the internal `Shoot` object. * Delete `ShootState` after restoration Only if the gardenlet is responsible for an unmanaged `Seed` - otherwise, its `shoot-state` reconciler wants to perform regular backups of the `ShootState`, so we shouldn't delete it even after successful restoration. * Disable `shoot-state` reconciler locally From gardener#8112 (comment): > In our e2e tests the cpm test shoots are always scheduled on a non-managed seed. With this, the controller would always be active and we wouldn't verify that migration also works without periodic backups. Since we don't need this periodic backup functionality in e2e tests, we simply disable the controller.
How to categorize this PR?
/area scalability
/kind enhancement
What this PR does / why we need it:
This PR drops the legacy
shootstate-extensions
andshootstate-secret
controllers.It also changes the
Shoot
flows such thatShootState
existence is no longer ensured at the beginning (after [GEP-22] Change control plane migration flow to fetch relevant shoot state ad-hoc and push it to theShootState
resource #8082, it gets created only on demand as part of the migration flow)ShootState
is deleted at the end of a successful restoration (only ifgardenlet
is not running the newShootState
controller introduced with [GEP-22] Perform regular state backups forShoot
s running on unmanagedSeed
s #8112)Additionally, as suggested in #8112 (comment), the new
ShootState
controller introduced with #8112 is disabled locally since it's not needed here and would only distort the e2e test results.Which issue(s) this PR fixes:
Part of #8073
Special notes for your reviewer:
The next step in the implementation of GEP-22 is cleaning up still existing
ShootState
s forShoot
s running onManagedSeed
s./cc @timebertt
Release note: