-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website Cleanup Part 6 - Proposals (Part 2) #7488
Website Cleanup Part 6 - Proposals (Part 2) #7488
Conversation
Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we keep updating the GEPs? Because when you navigate to https://gardener.cloud/docs/, they are part of the Gardener docs? Why they have to be part of the user facing docs? When I navigate to https://docs.k8s.io I don't see any KEPs. I would rather suggest excluding them from the gardener.cloud/docs and stop updating them with wording improvements or typo fixes.
I agree with @ialidzhikov. We can merge this PR now since work was invested already, though. |
I would like to first see change that excludes the GEPs from https://gardener.cloud/docs. |
Is this related to this PR in any way? |
I have created a PR that removes the Proposals section from the public website, as per @ialidzhikov's request. I'm open to any further suggestions. |
Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: aefb33f1b5834162e2ade33b0c30f92b0f7c06b3
|
Co-authored-by: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
@n-boshnakov: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 55255af110554f3b934d9fd879b24be510553e1b
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Proofread files * Update docs/proposals/20-ha-control-planes.md Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com> * Update docs/proposals/20-ha-control-planes.md Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com> * Apply suggestions from code review Co-authored-by: Sonu Kumar Singh <sonu.kumar.singh02@sap.com> --------- Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com> Co-authored-by: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
* Proofread files * Update docs/proposals/20-ha-control-planes.md Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com> * Update docs/proposals/20-ha-control-planes.md Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com> * Apply suggestions from code review Co-authored-by: Sonu Kumar Singh <sonu.kumar.singh02@sap.com> --------- Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com> Co-authored-by: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
How to categorize this PR?
/area documentation
/kind enhancement
What this PR does / why we need it:
This PR proofreads the Proposals section of the documentation. This is Part 2 of 2.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: