Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Cleanup Part 6 - Proposals (Part 2) #7488

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

n-boshnakov
Copy link
Contributor

How to categorize this PR?

/area documentation
/kind enhancement

What this PR does / why we need it:
This PR proofreads the Proposals section of the documentation. This is Part 2 of 2.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@gardener-prow gardener-prow bot added area/documentation Documentation related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Feb 15, 2023
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 15, 2023
Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
@n-boshnakov n-boshnakov requested review from ialidzhikov and removed request for rfranzke and shafeeqes February 15, 2023 09:51
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we keep updating the GEPs? Because when you navigate to https://gardener.cloud/docs/, they are part of the Gardener docs? Why they have to be part of the user facing docs? When I navigate to https://docs.k8s.io I don't see any KEPs. I would rather suggest excluding them from the gardener.cloud/docs and stop updating them with wording improvements or typo fixes.

@rfranzke
Copy link
Member

I agree with @ialidzhikov. We can merge this PR now since work was invested already, though.

@ialidzhikov
Copy link
Member

I would like to first see change that excludes the GEPs from https://gardener.cloud/docs.

@rfranzke
Copy link
Member

I would like to first see change that excludes the GEPs from https://gardener.cloud/docs.

Is this related to this PR in any way?

@n-boshnakov
Copy link
Contributor Author

n-boshnakov commented Feb 15, 2023

I have created a PR that removes the Proposals section from the public website, as per @ialidzhikov's request.

I'm open to any further suggestions.

Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 15, 2023

LGTM label has been added.

Git tree hash: aefb33f1b5834162e2ade33b0c30f92b0f7c06b3

docs/proposals/03-networking-extensibility.md Outdated Show resolved Hide resolved
docs/proposals/10-shoot-additional-container-runtimes.md Outdated Show resolved Hide resolved
docs/proposals/14-reversed-cluster-vpn.md Outdated Show resolved Hide resolved
docs/proposals/14-reversed-cluster-vpn.md Outdated Show resolved Hide resolved
docs/proposals/14-reversed-cluster-vpn.md Outdated Show resolved Hide resolved
docs/proposals/18-shoot-CA-rotation.md Outdated Show resolved Hide resolved
docs/proposals/18-shoot-CA-rotation.md Outdated Show resolved Hide resolved
Co-authored-by: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@n-boshnakov n-boshnakov requested review from acumino and removed request for ialidzhikov February 16, 2023 07:18
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 16, 2023

@n-boshnakov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-e2e-kind-ha-single-zone-upgrade d3538e9 link false /test pull-gardener-e2e-kind-ha-single-zone-upgrade

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 16, 2023

LGTM label has been added.

Git tree hash: 55255af110554f3b934d9fd879b24be510553e1b

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Feb 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
@gardener-prow gardener-prow bot merged commit 0413167 into gardener:master Feb 16, 2023
etiennnr pushed a commit to etiennnr/gardener that referenced this pull request Feb 21, 2023
* Proofread files

* Update docs/proposals/20-ha-control-planes.md

Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>

* Update docs/proposals/20-ha-control-planes.md

Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>

* Apply suggestions from code review

Co-authored-by: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>

---------

Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
Co-authored-by: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
andrerun pushed a commit to andrerun/gardener that referenced this pull request Jul 6, 2023
* Proofread files

* Update docs/proposals/20-ha-control-planes.md

Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>

* Update docs/proposals/20-ha-control-planes.md

Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>

* Apply suggestions from code review

Co-authored-by: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>

---------

Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
Co-authored-by: Sonu Kumar Singh <sonu.kumar.singh02@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Documentation related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants