Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a prerequisite #6056

Merged

Conversation

n-boshnakov
Copy link
Contributor

How to categorize this PR?

/area documentation
/kind enhancement

What this PR does / why we need it:
This PR adds a prerequisite to the guide.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@gardener-prow gardener-prow bot added area/documentation Documentation related kind/enhancement Enhancement, improvement, extension labels Jun 1, 2022
@n-boshnakov
Copy link
Contributor Author

n-boshnakov commented Jun 1, 2022

/review @JordanJordanov

@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 1, 2022
@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Jun 1, 2022
@n-boshnakov n-boshnakov closed this Jun 1, 2022
@n-boshnakov n-boshnakov reopened this Jun 1, 2022
@rfranzke rfranzke requested a review from ialidzhikov June 1, 2022 13:02
@rfranzke
Copy link
Member

rfranzke commented Jun 1, 2022

Does it make sense to include this in docs/deployment/getting_started_locally.md as well?

Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2022
@rfranzke
Copy link
Member

rfranzke commented Jun 2, 2022

/approve

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jun 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2022
@gardener-prow gardener-prow bot merged commit a4b7df8 into gardener:master Jun 2, 2022
krgostev pushed a commit to krgostev/gardener that referenced this pull request Jul 5, 2022
* Added a prerequisite

* Linked to the Local Setup guide

* Resolved comments

* Resolved comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Documentation related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants