Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minAllowed to VPA recommender and admission controller #3330

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Add minAllowed to VPA recommender and admission controller #3330

merged 1 commit into from
Dec 23, 2020

Conversation

vpnachev
Copy link
Member

@vpnachev vpnachev commented Dec 22, 2020 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind enhancement
/priority normal

What this PR does / why we need it:
Ensures some minimal CPU and memory to the VPA updater and admission controller pods.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The `vpa-admission-controller` and `vpa-updater` pods are now ensured with some minimal CPU and memory resources.

@vpnachev vpnachev requested a review from a team as a code owner December 22, 2020 20:58
@gardener-robot gardener-robot added kind/enhancement Enhancement, improvement, extension priority/normal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 22, 2020
@gardener-robot gardener-robot added the area/control-plane Control plane related label Dec 22, 2020
@gardener gardener deleted a comment from gardener-robot Dec 22, 2020
timebertt
timebertt approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timebertt timebertt merged commit df15d98 into gardener:master Dec 23, 2020
@vpnachev vpnachev deleted the vpa/min-resources branch December 23, 2020 18:12
@gardener-robot gardener-robot added priority/3 Priority (lower number equals higher priority) and removed priority/3 Priority (lower number equals higher priority) labels Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vpnachev @timebertt @gardener-robot-ci-3 @gardener-robot