Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only consider effective shoot for health checks #3286

Merged
merged 3 commits into from
Dec 15, 2020
Merged

Only consider effective shoot for health checks #3286

merged 3 commits into from
Dec 15, 2020

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Dec 10, 2020 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind bug
/priority normal

What this PR does / why we need it:
This PR changes the care controller in a way that health checks to be executed now consider only the effective shoot spec, i.e. respecting the .spec.maintenance.confineSpecRollout option. More information can be found in the linked issue.

Which issue(s) this PR fixes:
Fixes #2706

Release note:

Gardener health checks now take the effective Shoot specification into consideration if `.spec.maintenance.confineSpecRollout` is used. Earlier, `EveryNodeReady` or `ControlPlaneHealthy` conditions reported an invalid state if the specification was changed but not yet effective due to a rollout during shoot maintenance (`confineSpecRollout: true`).

@timuthy timuthy requested a review from a team as a code owner December 10, 2020 00:00
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion area/control-plane Control plane related kind/bug Bug size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 10, 2020
@timuthy
Copy link
Member Author

timuthy commented Dec 10, 2020

/remove kind api-change

@gardener-robot gardener-robot removed the kind/api-change API change with impact on API users label Dec 10, 2020
@timuthy @rfranzke
Write unkown condition on operation init failure
1e9e533 
Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>
@gardener-robot gardener-robot added the kind/api-change API change with impact on API users label Dec 11, 2020
@timuthy
Copy link
Member Author

timuthy commented Dec 11, 2020

/remove kind api-change
/cc @vlerenc 👀

@gardener-robot gardener-robot removed the kind/api-change API change with impact on API users label Dec 11, 2020
@gardener-robot gardener-robot added the kind/api-change API change with impact on API users label Dec 14, 2020
@timuthy timuthy removed kind/api-change API change with impact on API users reviewed/ok-to-test labels Dec 14, 2020
rfranzke
rfranzke approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@timuthy timuthy merged commit aec56a2 into gardener:master Dec 15, 2020
@timuthy timuthy deleted the fix.shoot-care branch December 18, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid health checks for shoots w/ confineSpecUpdateRollout
5 participants
@timuthy @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot