Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resources.gardener.cloud/skip-health-check=true annotation to CRDs #194

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Add resources.gardener.cloud/skip-health-check=true annotation to CRDs #194

merged 1 commit into from
Sep 22, 2023

Conversation

rfranzke
Copy link
Member

@rfranzke rfranzke commented Sep 22, 2023 •
edited
Loading

How to categorize this PR?

/area usability
/kind bug

What this PR does / why we need it:
Add resources.gardener.cloud/skip-health-check=true annotation to CRDs. Otherwise, gardener-resource-manager might recreate them too fast during shoot deletion after gardenlet just deleted them (and expects them to be gone). This can lead to race conditions, especially after gardener/gardener#7473.

This is just a workaround for now and needs to be figured out properly.

Special notes for your reviewer:
/cc @ScheererJ

Release note:

The `CustomResourceDefinition`s deployed to shoot clusters are now annotated with `resources.gardener.cloud/skip-health-check=true` to prevent `gardener-resource-manager` from recreating them too fast during shoot deletion.

@rfranzke rfranzke requested review from a team as code owners September 22, 2023 12:44
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 22, 2023
@gardener-robot gardener-robot added area/usability Usability related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Sep 22, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 22, 2023
@rfranzke rfranzke changed the title Add shoot.gardener.cloud/no-cleanup=true label to CRDs Add resources.gardener.cloud/skip-health-check=true annotations to CRDs Sep 22, 2023
@rfranzke rfranzke changed the title Add resources.gardener.cloud/skip-health-check=true annotations to CRDs Add resources.gardener.cloud/skip-health-check=true annotation to CRDs Sep 22, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 22, 2023
ScheererJ
ScheererJ approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 22, 2023
@ScheererJ ScheererJ merged commit 3ba3ff6 into gardener:master Sep 22, 2023
5 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 22, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 22, 2023
@rfranzke rfranzke deleted the add-no-cleanup-label branch September 22, 2023 13:39
@MartinWeindel MartinWeindel mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/usability Usability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfranzke @ScheererJ @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot