-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No alerting for certificates in error state #190
Conversation
/invite @istvanballok @rickardsjp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold for a second
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See minor caveat related to using and
in PromQL.
charts/internal/shoot-cert-management-seed/templates/configmap-observability.yaml
Outdated
Show resolved
Hide resolved
charts/internal/shoot-cert-management-seed/templates/configmap-observability.yaml
Outdated
Show resolved
Hide resolved
…-observability.yaml Co-authored-by: Istvan Ballok <istvan.zoltan.ballok@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area monitoring
/kind bug
What this PR does / why we need it:
If a cluster contains misconfigured certificates, the metrics
cert_management_cert_object_expire
reports a value of 0 and the alerting is triggered as the certificate seems to have expired since about 19600 days.To exclude such false alerts, the expression has been adapted.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: