Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor imagevector package to conform to usage pattern in gardener/gardener #181

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Refactor imagevector package to conform to usage pattern in gardener/gardener #181

merged 1 commit into from
Aug 21, 2023

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
The script vendor/github.com/gardener/.ci/set_dependency_version
was changed with gardener/gardener#8250.
It is used for generating automatic PRs in is used in .ci/set_dependency_version if dependent images are updated.
The images.yaml are now expected at imagevector/images.yaml instead at charts/images.yaml. This PR adjust to this new pattern to avoid duplicating the script.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Refactor imagevector package to conform to usage pattern in gardener/gardener

@MartinWeindel MartinWeindel requested review from a team as code owners August 21, 2023 08:45
@gardener-robot gardener-robot added needs/review Needs review area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 21, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 21, 2023
ScheererJ
ScheererJ approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 21, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 21, 2023
@MartinWeindel MartinWeindel merged commit 6cc4f53 into master Aug 21, 2023
1 check passed
@MartinWeindel MartinWeindel deleted the imagevector-refactoring branch August 21, 2023 09:31
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MartinWeindel @ScheererJ @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot