Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor gardener@1.65.3 and add ShootSystemComponentsHealthy to conditionTypesToRemove #154

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Vendor gardener@1.65.3 and add ShootSystemComponentsHealthy to conditionTypesToRemove #154

merged 2 commits into from
Mar 21, 2023

Conversation

shafeeqes
Copy link
Contributor

@shafeeqes shafeeqes commented Mar 21, 2023 •
edited
Loading

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:
For the reasoning, please check gardener/gardener#6775 (comment) and gardener/gardener#7660.
We need to add the healthcheck controller back and add ShootSystemComponentsHealthy to conditionTypesToRemove.

Which issue(s) this PR fixes:
Part of gardener/gardener#6775

Special notes for your reviewer:

Release note:

The stale healthcheck conditions from the `shoot-cert-service` extension are now properly cleaned up.

The following dependency is updated:
- github.com/gardener/gardener: v1.65.0 -> v1.65.3

@shafeeqes shafeeqes requested review from a team as code owners March 21, 2023 05:10
@gardener-robot gardener-robot added area/control-plane Control plane related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Mar 21, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 21, 2023
This was referenced Mar 21, 2023
Closed
Closed
Merged
MartinWeindel
MartinWeindel approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 21, 2023
@MartinWeindel MartinWeindel merged commit 40ef6c3 into gardener:master Mar 21, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 21, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 21, 2023
@shafeeqes shafeeqes deleted the vendor/gardener@1.65 branch March 21, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
area/control-plane Control plane related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shafeeqes @MartinWeindel @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot