Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the v1alpha1 API #141

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Remove the v1alpha1 API #141

merged 2 commits into from
Feb 15, 2024

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Feb 7, 2024 •
edited
Loading

How to categorize this PR?

/kind cleanup

What this PR does / why we need it:
The PR removes the v1alpha1 API.

Which issue(s) this PR fixes:
Part of #3

Special notes for your reviewer:

Release note:

The `registry.extensions.gardener.cloud/v1alpha1` API version is removed. Use `registry.extensions.gardener.cloud/v1alpha2` instead.

The `registry.extensions.gardener.cloud/v1alpha1` API version is removed. Before upgrading to this version, make sure that there are no usages of the `registry.extensions.gardener.cloud/v1alpha1` API version in the landscape.

@gardener-prow gardener-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added the kind/cleanup Something that is not needed anymore and can be cleaned up label Feb 7, 2024
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 7, 2024
@ialidzhikov ialidzhikov mentioned this pull request Feb 7, 2024
Closed
96 tasks
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 7, 2024
@gardener-prow gardener-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 9, 2024
@ialidzhikov ialidzhikov marked this pull request as ready for review February 9, 2024 09:11
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2024
@ialidzhikov
Copy link
Member Author

/hold
until v0.6.0 is released

@gardener-prow gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024
@ialidzhikov
Copy link
Member Author

/hold cancel
v0.6.0 is released

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2024
dimitar-kostadinov
dimitar-kostadinov reviewed Feb 15, 2024
View reviewed changes
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 15, 2024

LGTM label has been added.

Git tree hash: c4c69fdee55c57aa5cd3ebb2c2725343ee9d4aa8

@ialidzhikov
Copy link
Member Author

/approve

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Feb 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2024
@gardener-prow gardener-prow bot merged commit 96d8d20 into gardener:main Feb 15, 2024
6 checks passed
@ialidzhikov ialidzhikov deleted the cleanup/v1alpha1-api branch February 15, 2024 16:32
@JordanJordanov JordanJordanov added area/ipcei IPCEI (Important Project of Common European Interest) ipcei/registry-cache-extension Registry Cache Extension labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitar-kostadinov dimitar-kostadinov dimitar-kostadinov left review comments

@rfranzke rfranzke Awaiting requested review from rfranzke

@timebertt timebertt Awaiting requested review from timebertt

Assignees

@dimitar-kostadinov dimitar-kostadinov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. ipcei/registry-cache-extension Registry Cache Extension kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ialidzhikov @dimitar-kostadinov @JordanJordanov