Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.3] admission: Allow the admission Pod to resolve dns #108

Merged
merged 1 commit into from
Dec 8, 2023
Merged

[release-v0.3] admission: Allow the admission Pod to resolve dns #108

merged 1 commit into from
Dec 8, 2023

Conversation

gardener-ci-robot
Copy link

@gardener-ci-robot gardener-ci-robot commented Dec 8, 2023 •
edited
Loading

This is an automated cherry-pick of #107

/assign ialidzhikov

admission: An issue preventing the admission Pod to perform DNS resolutions is now fixed. Previously, the admission was denying requests when the `providerConfig.caches[].secretReferenceName` field is specified because it was not able to resolve the virtual kube-apiserver DNS name.

@gardener-ci-robot gardener-ci-robot mentioned this pull request Dec 8, 2023
Merged
@gardener-prow gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Dec 8, 2023
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 8, 2023
ialidzhikov
ialidzhikov approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2023
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 8, 2023

LGTM label has been added.

Git tree hash: ee97c29eb58aa35b9150722a1048d7cb9c324371

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2023
@gardener-prow gardener-prow bot merged commit 99c2a7f into gardener:release-v0.3 Dec 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees

@ialidzhikov ialidzhikov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gardener-ci-robot @ialidzhikov