Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ensurer): add additional units and files for lvm disk provisioni… #325

Merged
merged 8 commits into from
Oct 16, 2024
Merged

feat(ensurer): add additional units and files for lvm disk provisioni… #325

merged 8 commits into from
Oct 16, 2024
+157 −0

Conversation

RiRa12621
Copy link
Collaborator

@RiRa12621 RiRa12621 commented Sep 19, 2024 •
edited
Loading

…ng on flatcar

How to categorize this PR?
/area storage
/kind enhancement
/platform equinix-metal

What this PR does / why we need it:
This is PR allows to use all volumes for containerd, using LVM.

As instances on Equinix are preconfigured in terms of disks, operators want to be able to use all disks and not constantly run out of space, while there's theoretically multiple untouched disks left.

This PR creates a unit that executes a script to use LVM to make use of all volumes and another unit to then mount the new volume to /var/lib/containerd.

Special notes for your reviewer:
This only applies to flatcar linux but using a switch/case statement, if more distros will be added in the future.
The code has to depend on the distro, as potentially every OS does things differently.

LVM on flatcar hasn't be documented but working --> flatcar/flatcar-website#362
Release note:

The provider-equinix-metal extension now allows to use all volumes of an equinix instance under the followibng conditions:
* use flatcar linux
* use only one OS
* use containerd as container engine

@gardener-robot gardener-robot added the needs/review Needs review label Sep 19, 2024
@RiRa12621
Copy link
Collaborator Author

/assign @schrodit

@gardener-robot gardener-robot added area/storage Storage related kind/enhancement Enhancement, improvement, extension platform/equinix-metal Equinix Metal platform/infrastructure (previously Packet) labels Sep 19, 2024
@gardener-robot
Copy link

@RiRa12621 Thank you for your contribution.

@gardener-robot gardener-robot added the size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) label Sep 19, 2024
schrodit
schrodit reviewed Sep 19, 2024
View reviewed changes
pkg/webhook/controlplane/ensurer.go Outdated Show resolved Hide resolved
pkg/webhook/controlplane/ensurer.go Outdated Show resolved Hide resolved
schrodit
schrodit reviewed Sep 23, 2024
View reviewed changes
pkg/webhook/controlplane/ensurer.go Outdated Show resolved Hide resolved
pkg/webhook/controlplane/ensurer.go Outdated Show resolved Hide resolved
pkg/webhook/controlplane/ensurer.go Show resolved Hide resolved
@RiRa12621
feat(ensurer): PR comments
f4d16d3 
* added information about behaviour
* adjusted code for readability
* error handling for non-homgenous fleets
@RiRa12621
Copy link
Collaborator Author

/retest

@gardener-robot gardener-robot added the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 11, 2024
@schrodit schrodit added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 11, 2024
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 11, 2024
@RiRa12621
Copy link
Collaborator Author

/ok-to-test

@RiRa12621 RiRa12621 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 11, 2024
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 11, 2024
@RiRa12621 RiRa12621 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 14, 2024
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 14, 2024
@RiRa12621 RiRa12621 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 15, 2024
schrodit
schrodit previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add the caveats in the release notes

README.md Outdated Show resolved Hide resolved
pkg/webhook/controlplane/ensurer.go Outdated Show resolved Hide resolved
@ci-shared-oss-pipeline-0 ci-shared-oss-pipeline-0 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 16, 2024
@RiRa12621 RiRa12621 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 16, 2024
schrodit
schrodit approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@schrodit schrodit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 16, 2024
@petersutter
Copy link
Member

/cla

@gardener-robot
Copy link

@petersutter I reached out successfully to the cla-assistant to recheck this pull request.

@RiRa12621 RiRa12621 merged commit de807fb into gardener:master Oct 16, 2024
6 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schrodit schrodit schrodit approved these changes

@jonas-zipprick jonas-zipprick Awaiting requested review from jonas-zipprick jonas-zipprick is a code owner

Assignees

@schrodit schrodit

Labels
area/storage Storage related kind/enhancement Enhancement, improvement, extension platform/equinix-metal Equinix Metal platform/infrastructure (previously Packet) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RiRa12621 @gardener-robot @petersutter @schrodit @ci-shared-oss-pipeline-0