Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor gardener/gardener@v1.39.4 #490

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Vendor gardener/gardener@v1.39.4 #490

merged 1 commit into from
Feb 8, 2022

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Feb 4, 2022 •
edited
Loading

/kind bug
/platform aws

Compared to gardener/gardener@v1.39.0, gardener/gardener@v1.39.4 contains the following fixes that are related to the extension library:

Fixes #482

Release note:

The following dependency is updated:
- github.com/gardener/gardener: v1.39.0 -> v1.39.4

@ialidzhikov ialidzhikov requested review from a team as code owners February 4, 2022 12:47
@gardener-robot gardener-robot added kind/bug Bug platform/aws Amazon web services platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 4, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 4, 2022
@ialidzhikov
Copy link
Member Author

ialidzhikov commented Feb 7, 2022 •
edited
Loading

/milestone v1.33
as the broken Worker restore operation would be a regression compared to provider-aws@v1.32.0

@gardener-robot gardener-robot added this to the v1.33 milestone Feb 7, 2022
@ialidzhikov ialidzhikov removed the needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 7, 2022
dkistner
dkistner previously approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 8, 2022
@ialidzhikov
Copy link
Member Author

/hold
as I plan to update this PR with vendoring of v1.39.4

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Feb 8, 2022
@ialidzhikov
Vendor gardener/gardener@v1.39.4
87653b4 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov changed the title Vendor gardener/gardener@v1.39.3 Vendor gardener/gardener@v1.39.4 Feb 8, 2022
@gardener-robot gardener-robot added needs/review Needs review and removed needs/review Needs review labels Feb 8, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 8, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 8, 2022
@ialidzhikov
Copy link
Member Author

/test

@testmachinery
Copy link

testmachinery bot commented Feb 8, 2022 •
edited
Loading

Testrun: e2e-c9pxq
Workflow: e2e-c9pxq-wf
Phase: Succeeded

+---------------------+---------------------+-----------+----------+
|        NAME         |        STEP         |   PHASE   | DURATION |
+---------------------+---------------------+-----------+----------+
| infrastructure-test | infrastructure-test | Succeeded | 15m41s   |
| bastion-test        | bastion-test        | Succeeded | 5m3s     |
| dnsrecord-test      | dnsrecord-test      | Succeeded | 7m0s     |
+---------------------+---------------------+-----------+----------+

@ialidzhikov ialidzhikov removed the kind/test Test label Feb 8, 2022
@ialidzhikov
Copy link
Member Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Feb 8, 2022
rfranzke
rfranzke approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

dkistner
dkistner approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@dkistner dkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ialidzhikov ialidzhikov merged commit 0c26ffd into gardener:master Feb 8, 2022
@ialidzhikov ialidzhikov deleted the gardener@v1.39.3 branch February 8, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkistner dkistner dkistner approved these changes

@rfranzke rfranzke rfranzke approved these changes

Assignees
No one assigned
Labels
kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.

Bastion integration test is failing
7 participants
@ialidzhikov @dkistner @rfranzke @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot