Kubernetes Version Configurability per Worker Pool #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/usability
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
rfranzke
force-pushed
the
enh/kubeletversion
branch
from
274fda7
to
6a8a4c1
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
rfranzke
force-pushed
the
enh/kubeletversion
branch
from
6a8a4c1
to
1214a2e
Compare
|
/ready |
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
|
/reviewed ok-to-test |
gardener-robot
added
the
reviewed/ok-to-test
|
/rebase |
gardener-robot
added
needs/rebase
rfranzke
force-pushed
the
enh/kubeletversion
branch
from
1214a2e
to
4aa478f
Compare
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
dkistner
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind enhancement
/platform aws
/merge squash
What this PR does / why we need it:
This PR implements support for
gardener/gardener'sWorkerPoolKubernetesVersionfeature gate. As explained in gardener/gardener#3501 (comment), itcontrolpanewebhook to use the effective kubelet version when computing the CSI migration feature gate names.Which issue(s) this PR fixes:
Part of gardener/gardener#3501
Special notes for your reviewer:
✅
Depends on #478, hence, PR is in draft state.Release note:
This extension does now support `gardener/gardener`'s `WorkerPoolKubernetesVersion` feature gate, i.e., having [worker pools with overridden Kubernetes versions](https://github.com/gardener/gardener/blob/8a9c88866ec5fce59b5acf57d4227eeeb73669d7/example/90-shoot.yaml#L69-L70).In case `gardener/gardener`'s `WorkerPoolKubernetesVersion` feature gate is enabled, it's possible having [worker pools with overridden Kubernetes versions](https://github.com/gardener/gardener/blob/8a9c88866ec5fce59b5acf57d4227eeeb73669d7/example/90-shoot.yaml#L69-L70) for `Shoot`s whose `.spec.kubernetes.version` is greater or equal than the CSI migration version (`1.18`).