shoot webhook: Clean up obsolete mutations and add object selector #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/scalability
gardener-robot-ci-3
added
the
reviewed/ok-to-test
17 tasks
gardener-robot-ci-3
added
needs/ok-to-test
After ReversedVPN feature is unconditionally enabled, there is no longer a Service kube-system/vpn-shoot in the Shoot cluster
ialidzhikov
force-pushed
the
enh/shoot-webhook-object-selector
branch
from
f8fd726
to
a227940
Compare
gardener-robot
added
the
size/m
gardener-robot
removed
the
size/xl
gardener-robot-ci-1
added
reviewed/ok-to-test
After gardener/gardener#4884 it should no longer be required to have the mutation of the metrics-server Deployment.
ialidzhikov
force-pushed
the
enh/shoot-webhook-object-selector
branch
from
a227940
to
c59651e
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
shaoyongfeng
approved these changes
Sep 18, 2024
|
/test |
|
Testrun: e2e-mtsk8 +---------------------+---------------------+-----------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+-----------+----------+ | infrastructure-test | infrastructure-test | Succeeded | 22m0s | | bastion-test | bastion-test | Succeeded | 7m13s | +---------------------+---------------------+-----------+----------+ |
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area scalability
/kind enhancement
/platform alicloud
What this PR does / why we need it:
1st commit: After ReversedVPN feature is unconditionally enabled, there is no longer a Service kube-system/vpn-shoot in the Shoot cluster.
2nd commit: After gardener/gardener#4884 it should no longer be required to have the mutation of the metrics-server Deployment.
3th commit: Similar to gardener/gardener-extension-provider-aws#988
Which issue(s) this PR fixes:
Part of gardener/gardener#9864
Special notes for your reviewer:
N/A
Release note: