-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove VPA (min|max)Allowed
settings.
#408
Remove VPA (min|max)Allowed
settings.
#408
Conversation
`minAllowed` may cause wasted resources while `maxAllowed` may cause under-reservation and hence noisy neighbor issues. This change removes the settings per default from the admission controller and the extension.
f4a248a
to
1321eff
Compare
/lgtm |
@ScheererJ: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
How to categorize this PR?
/area networking
/area auto-scaling
/kind enhancement
What this PR does / why we need it:
Remove VPA
(min|max)Allowed
settings.minAllowed
may cause wasted resources whilemaxAllowed
may cause under-reservation and hence noisy neighbor issues. This change removes the settings per default from the admission controller and the extension.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: