Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish separate admission Helm charts #376

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Publish separate admission Helm charts #376

merged 1 commit into from
Aug 2, 2024

Conversation

oliver-goetz
Copy link
Member

@oliver-goetz oliver-goetz commented Aug 1, 2024 •
edited
Loading

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:
Admission Helm charts have to be published as separate charts for application and runtime.

Which issue(s) this PR fixes:
Fixes #369

Special notes for your reviewer:

Release note:

NONE

@oliver-goetz oliver-goetz requested review from a team as code owners August 1, 2024 16:05
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/enhancement Enhancement, improvement, extension size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Aug 1, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 1, 2024
ScheererJ
ScheererJ approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ScheererJ ScheererJ merged commit cdfa652 into gardener:master Aug 2, 2024
9 checks passed
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review labels Aug 2, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 2, 2024
@oliver-goetz oliver-goetz deleted the enh/publish-separate-admission-charts branch August 2, 2024 07:13
This was referenced Aug 2, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScheererJ ScheererJ ScheererJ approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliver-goetz @ScheererJ @gardener-robot-ci-2 @gardener-robot