Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix versioning in charts #225

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix versioning in charts #225

merged 1 commit into from
Oct 25, 2023

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/area networking
/kind bug

What this PR does / why we need it:
Some charts were missed to be adapted in cec9afe.
This PR adapts them.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

An issue in the charts missing versions for some resources is now fixed.

@shafeeqes shafeeqes requested review from a team as code owners October 25, 2023 06:41
@gardener-robot gardener-robot added area/networking Networking related kind/bug Bug needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Oct 25, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 25, 2023
DockToFuture
DockToFuture approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@DockToFuture DockToFuture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 25, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 25, 2023
@DockToFuture DockToFuture merged commit 3a71b05 into gardener:master Oct 25, 2023
8 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 25, 2023
DockToFuture pushed a commit that referenced this pull request Oct 25, 2023
@shafeeqes @DockToFuture
Fix charts (#225)
6147fa7
@shafeeqes shafeeqes deleted the fix/charts branch October 26, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DockToFuture DockToFuture DockToFuture approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shafeeqes @DockToFuture @gardener-robot-ci-2 @gardener-robot