Adjust resource requests and autoscaling of calico-node side car containers.
#489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containers. The side car containers use negligible amount of resources compared to `calico-node`. Therefore, requests likely just waste resources. Similarly, they fall below the minimum threshold of VPA. Hence, autoscaling them does not make sense. `minAllowed` and `maxAllowed` of `calico-node` also are not that useful. Therefore, they are removed as well.
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
area/networking
gardener-robot-ci-3
added
needs/ok-to-test
|
/lgtm |
gardener-robot
added
reviewed/lgtm
axel7born
previously approved these changes
Sep 19, 2024
gardener-robot-ci-3
added
the
reviewed/ok-to-test
|
Hmm... isn't removing a container from the VPA spec resulting in applying the default configuration, i.e. whatever is defined in cc @voelzmo |
gardener-robot
added
needs/review
Good point. Adjusted accordingly with 0f5afa2. |
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
axel7born
approved these changes
Sep 20, 2024
|
Thanks @ScheererJ. I also checked in the meantime VPA and it requires the container indeed to be put explicitly into |
gardener-robot
added
the
status/closed
ScheererJ
added a commit
to ScheererJ/gardener-extension-networking-calico
that referenced
this pull request
Sep 23, 2024
`minAllowed` may cause wasted resources while `maxAllowed` may cause under-reservation and hence noisy neighbor issues. This change removes them building on previous work in gardener#489. They are removed from `kube-controllers`, `calico-typha`, the admission controller and the extension.
ScheererJ
added a commit
to ScheererJ/gardener-extension-networking-calico
that referenced
this pull request
Sep 23, 2024
`minAllowed` may cause wasted resources while `maxAllowed` may cause under-reservation and hence noisy neighbor issues. This change removes them building on previous work in gardener#489. They are removed from `kube-controllers`, `calico-typha`, the admission controller and the extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area networking
/kind enhancement
What this PR does / why we need it:
Adjust resource requests and autoscaling of
calico-nodeside car containers.The side car containers use negligible amount of resources compared to
calico-node. Therefore, requests likely just waste resources. Similarly, they fall below the minimum threshold of VPA. Hence, autoscaling them does not make sense.minAllowedandmaxAllowedofcalico-nodealso are not that useful. Therefore, they are removed as well.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: