-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust resource requests and autoscaling of calico-node
side car containers.
#489
base: master
Are you sure you want to change the base?
Conversation
containers. The side car containers use negligible amount of resources compared to `calico-node`. Therefore, requests likely just waste resources. Similarly, they fall below the minimum threshold of VPA. Hence, autoscaling them does not make sense. `minAllowed` and `maxAllowed` of `calico-node` also are not that useful. Therefore, they are removed as well.
/lgtm |
Hmm... isn't removing a container from the VPA spec resulting in applying the default configuration, i.e. whatever is defined in cc @voelzmo |
Good point. Adjusted accordingly with 0f5afa2. |
Thanks @ScheererJ. I also checked in the meantime VPA and it requires the container indeed to be put explicitly into |
How to categorize this PR?
/area networking
/kind enhancement
What this PR does / why we need it:
Adjust resource requests and autoscaling of
calico-node
side car containers.The side car containers use negligible amount of resources compared to
calico-node
. Therefore, requests likely just waste resources. Similarly, they fall below the minimum threshold of VPA. Hence, autoscaling them does not make sense.minAllowed
andmaxAllowed
ofcalico-node
also are not that useful. Therefore, they are removed as well.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: