Skip to content

test-e2e-provider-local.sh: Use skaffold instead of make docker-images and kind load docker-image #446

Open

Description

How to categorize this issue?

/area networking
/kind enhancement

What would you like to be added:

make docker-images
docker tag europe-docker.pkg.dev/gardener-project/public/gardener/extensions/networking-calico:latest networking-calico-local:$version
kind load docker-image networking-calico-local:$version --name gardener-local
mkdir -p $repo_root/tmp
cp -f $repo_root/example/controller-registration.yaml $repo_root/tmp/controller-registration.yaml
yq -i e "(select (.helm.values.image) | .helm.values.image.tag) |= \"$version\"" $repo_root/tmp/controller-registration.yaml
yq -i e '(select (.helm.values.image) | .helm.values.image.repository) |= "docker.io/library/networking-calico-local"' $repo_root/tmp/controller-registration.yaml
kubectl apply --server-side --force-conflicts -f "$repo_root/tmp/controller-registration.yaml"
to be changed to something like https://github.com/gardener/gardener-extension-registry-cache/blob/c924400d255feba1266d5f943a2e64ec625ff210/hack/ci-e2e-kind.sh#L36-L40.

make docker-images pulls the golang image from docker.io defined in the Dockerfile. With skaffold this is likely avoided.

Why is this needed:
To prevent dockerhub rate limit issues for e2e executions in prow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions