Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider PowerDNS implementation #390

Merged

Conversation

simcod
Copy link
Contributor

@simcod simcod commented Sep 3, 2024

What this PR does / why we need it:
Adds PowerDNS as additional provider.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Adds PowerDNS as additional provider

@CLAassistant
Copy link

CLAassistant commented Sep 3, 2024

CLA assistant check
All committers have signed the CLA.

@gardener-robot
Copy link

@simcod Thank you for your contribution.

@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 3, 2024
@gardener-robot-ci-1
Copy link
Contributor

Thank you @simcod for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

@simcod simcod changed the title Provider powerdns implementation Provider PowerDNS implementation Sep 3, 2024
@MartinWeindel
Copy link
Member

MartinWeindel commented Sep 4, 2024

@simcod
Thanks for your contribution!

As I'm not very familiar with PowerDNS, can you explain, why it is not sufficient to use the the provider type rfc2136 for PowerDNS. According to the documentation it should support it.
Have you tried it?

@robertvolkmann
Copy link

Hi @MartinWeindel, we've opted to use the REST interface of PowerDNS to maintain consistency with the code base of our PowerDNS extension.

@simcod simcod marked this pull request as ready for review September 11, 2024 07:00
@simcod simcod requested a review from a team as a code owner September 11, 2024 07:00
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Sep 11, 2024
@simcod
Copy link
Contributor Author

simcod commented Oct 2, 2024

@MartinWeindel Thank you for your feedback.

I added documentation about credentials and examples.

Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your contribution!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Oct 8, 2024
@MartinWeindel MartinWeindel merged commit 735cd31 into gardener:master Oct 8, 2024
2 checks passed
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 8, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants