-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider PowerDNS implementation #390
Provider PowerDNS implementation #390
Conversation
@simcod Thank you for your contribution. |
Thank you @simcod for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
@simcod As I'm not very familiar with PowerDNS, can you explain, why it is not sufficient to use the the provider type |
Hi @MartinWeindel, we've opted to use the REST interface of PowerDNS to maintain consistency with the code base of our PowerDNS extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Implementation looks good to me.
Please add documentation about credentials secrets and examples.
Similar to:
- https://github.com/gardener/external-dns-management/blob/master/README.md?plain=1#L15
- https://github.com/gardener/external-dns-management/tree/master/docs/rfc2136
- https://github.com/gardener/external-dns-management/blob/master/examples/20-secret-rfc2136-credentials.yaml
- https://github.com/gardener/external-dns-management/blob/master/examples/30-provider-rfc2136.yaml
@MartinWeindel Thank you for your feedback. I added documentation about credentials and examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for your contribution!
What this PR does / why we need it:
Adds PowerDNS as additional provider.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: