Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor components to use default labels and owner references from etcd #559

Merged

Commits on May 31, 2023

  1. Refactor: Update configmap component to use default labels and owne…

    …r references from `etcd`.
    
    This commit refactors the `configmap` component to use the default labels and owner references provided by etcd. Specifically, we removed the functions `getOwnerReferences` and `getObjectMeta`, and instead used the `GetEtcdAsOwnerReference` and `GetDefaultLabels` functions.
    
    In addition, we improved the formulation of the configmap by adding a new function called `getEtcdConfigYaml`.
    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    9e5bb9b View commit details
    Browse the repository at this point in the history
  2. Refactor: Update lease component to use default labels and owner re…

    …ferences from `etcd`.
    
    This commit refactors the `lease` component to use the default labels and owner references provided by etcd. Specifically, we removed the functions `getOwnerReferences`, and instead used the `GetEtcdAsOwnerReference` and `GetDefaultLabels` functions.
    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    99873dc View commit details
    Browse the repository at this point in the history
  3. Refactor: Update poddisruptionbudget component to use default label…

    …s and owner references from `etcd`.
    
    This commit refactors the `poddisruptionbudget` component to use the default labels and owner references provided by etcd. Specifically, we removed the functions `getOwnerReferences`, and instead used the `GetEtcdAsOwnerReference` and `GetDefaultLabels` functions.
    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5f5e90d View commit details
    Browse the repository at this point in the history
  4. Refactor: Update service component to use default labels and owner …

    …references from `etcd`.
    
    This commit refactors the `service` component to use the default labels and owner references provided by etcd. Specifically, removed the functions `getOwnerReferences`, `getSelectors`, `getLabels` and instead used the `GetEtcdAsOwnerReference` and `GetDefaultLabels` functions.
    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4b557ee View commit details
    Browse the repository at this point in the history
  5. Refactor: Update statefulset component to use default labels and ow…

    …ner references from `etcd`.
    
    This commit refactors the `statefulset` component to use the default labels and owner references provided by etcd. Specifically, removed the functions `getCommonLabels` and instead used the `GetAsOwnerReference` and `GetDefaultLabels` functions.
    
    Fix intergration test
    
    rebase with master
    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    aa12001 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    40fe384 View commit details
    Browse the repository at this point in the history
  7. Addressed review comment from Madhav about OwnerReferences.

    This commit addresses the review comment gardener#539 (comment)
    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    3a879d0 View commit details
    Browse the repository at this point in the history
  8. This commit addresses the review comment from Shreyas about improving…

    … the service account test in response to gardener#538 (review)
    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    cfd9b47 View commit details
    Browse the repository at this point in the history
  9. Refactor API version to use 'druidv1alpha1.GroupVersion.String()' ins…

    …tead of the static string 'druid.gardener.cloud/v1alpha1
    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    41835d7 View commit details
    Browse the repository at this point in the history
  10. Addressed review comment

    - Updated function `GetAsOwnerReference to return metav1.OwnerReference instead of *metav1.OwnerReference
    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f697e05 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4f94694 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    dc67736 View commit details
    Browse the repository at this point in the history
  13. Removed arguments of emptyPodDisruptionBudget and reused name, namesp…

    …ace from component's value
    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    50eaa9e View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    d8a4a13 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    175b5df View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    56efc9f View commit details
    Browse the repository at this point in the history
  17. make revendor

    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    7d2832f View commit details
    Browse the repository at this point in the history
  18. fix failing test

    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    a5a9440 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    a55c6e7 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    bf89a7f View commit details
    Browse the repository at this point in the history
  21. Removed JSON tags

    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    683f0c1 View commit details
    Browse the repository at this point in the history
  22. Rebase with master

    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    7840a6f View commit details
    Browse the repository at this point in the history
  23. Fix integration test

    seshachalam-yv committed May 31, 2023
    Configuration menu
    Copy the full SHA
    78bd923 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2023

  1. Fix failing test

    seshachalam-yv committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    c69fe26 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Apply suggestions from code review

    Co-authored-by: Aaron Francis Fernandes <79958509+aaronfern@users.noreply.github.com>
    seshachalam-yv and aaronfern authored Jun 5, 2023
    Configuration menu
    Copy the full SHA
    31c66b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    539e7d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Apply suggestions from code review

    Co-authored-by: Shreyas Rao <42259948+shreyas-s-rao@users.noreply.github.com>
    seshachalam-yv and shreyas-s-rao authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    6edd92d View commit details
    Browse the repository at this point in the history
  2. Addressed review comment

    - Renamed field `PodAdditionalLabels` to `AdditionalPodLabels`.
    seshachalam-yv committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    975e66f View commit details
    Browse the repository at this point in the history
  3. Update pkg/component/etcd/configmap/values.go

    Co-authored-by: Shreyas Rao <42259948+shreyas-s-rao@users.noreply.github.com>
    seshachalam-yv and shreyas-s-rao authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    ea9f5ae View commit details
    Browse the repository at this point in the history
  4. Fixed typo

    seshachalam-yv committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b85a38b View commit details
    Browse the repository at this point in the history