Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cosmetics and streamlining after controller-runtime refactoring #558

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Minor cosmetics and streamlining after controller-runtime refactoring #558

merged 1 commit into from
Mar 28, 2023

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/area quality robustness
/kind enhancement

What this PR does / why we need it:
This PR does some minor cosmetics and streamlining after the major refactoring in #506
Now we use builder wherever possible, and the builder functions are arranged consistently.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/cc @shreyas-s-rao

Release note:

NONE

@shafeeqes shafeeqes requested a review from a team as a code owner March 17, 2023 09:43
@gardener-robot gardener-robot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Mar 17, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 17, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 17, 2023
seshachalam-yv
seshachalam-yv approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@seshachalam-yv seshachalam-yv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 17, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 17, 2023
unmarshall
unmarshall approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aaronfern aaronfern added this to the v0.17.0 milestone Mar 28, 2023
@unmarshall unmarshall merged commit 0299799 into gardener:master Mar 28, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 28, 2023
@shafeeqes shafeeqes deleted the cosmetics/controller branch March 28, 2023 09:27
seshachalam-yv pushed a commit to seshachalam-yv/etcd-druid that referenced this pull request Apr 6, 2023
@shafeeqes @seshachalam-yv
Minor cosmetics and streamlining (gardener#558)
2e5db9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

@seshachalam-yv seshachalam-yv seshachalam-yv approved these changes

Assignees
No one assigned
Labels
area/quality Output qualification (tests, checks, scans, automation in general, etc.) related area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.
8 participants
@shafeeqes @unmarshall @seshachalam-yv @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot @aaronfern