-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ServiceAccount
Helm charts into component
#535
Refactor ServiceAccount
Helm charts into component
#535
Conversation
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I suggested few changes.
Test failing? |
Thanks @abdasgupta for review, tests are fixed now. PTAL |
/remove approve |
@unmarshall Label approve does not exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
- Remove serviceaccount from template yaml from chart - Add unit tests for serviceaccount component
5c6f260
to
4303c81
Compare
- Remove serviceaccount from template yaml from chart - Add unit tests for serviceaccount component
How to categorize this PR?
/area robustness
/kind enhancement
What this PR does / why we need it:
This PR refactors the
etcd-druid
serviceaccount
helm charts in Golang component and adds unit tests.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: