Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ServiceAccount Helm charts into component #535

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Refactor ServiceAccount Helm charts into component #535

merged 1 commit into from
Mar 29, 2023

Conversation

seshachalam-yv
Copy link
Contributor

@seshachalam-yv seshachalam-yv commented Feb 22, 2023 •
edited
Loading

How to categorize this PR?

/area robustness
/kind enhancement

What this PR does / why we need it:

This PR refactors the etcd-druid serviceaccount helm charts in Golang component and adds unit tests.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Eliminated `ServiceAccount` helm charts and converted into Golang component with added unit tests.

@seshachalam-yv seshachalam-yv requested a review from a team as a code owner February 22, 2023 14:00
@gardener-robot gardener-robot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Feb 22, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 22, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 22, 2023
@seshachalam-yv
Copy link
Contributor Author

/retest

abdasgupta
abdasgupta suggested changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@abdasgupta abdasgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I suggested few changes.

pkg/component/etcd/serviceaccount/serviceaccount.go Outdated Show resolved Hide resolved
pkg/component/etcd/serviceaccount/serviceaccount.go Outdated Show resolved Hide resolved
pkg/component/etcd/serviceaccount/values_helper.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Feb 27, 2023
@abdasgupta
Copy link
Contributor

Test failing?

@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 27, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 27, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 27, 2023
@seshachalam-yv
Copy link
Contributor Author

Test failing?

Thanks @abdasgupta for review, tests are fixed now. PTAL

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 27, 2023
@seshachalam-yv seshachalam-yv mentioned this pull request Feb 28, 2023
Closed
8 tasks
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 28, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 28, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 13, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 13, 2023
unmarshall
unmarshall reviewed Mar 21, 2023
View reviewed changes
api/v1alpha1/types_etcd.go Outdated Show resolved Hide resolved
controllers/etcd/reconciler.go Outdated Show resolved Hide resolved
controllers/etcd/reconciler.go Outdated Show resolved Hide resolved
controllers/etcd/reconciler.go Outdated Show resolved Hide resolved
pkg/component/etcd/serviceaccount/values_helper_test.go Outdated Show resolved Hide resolved
pkg/component/etcd/serviceaccount/serviceaccount.go Outdated Show resolved Hide resolved
pkg/component/etcd/serviceaccount/serviceaccount_test.go Show resolved Hide resolved
@unmarshall
Copy link
Contributor

/remove approve

@gardener-robot
Copy link

@unmarshall Label approve does not exist.

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 23, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 23, 2023
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Mar 27, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 27, 2023
unmarshall
unmarshall approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Mar 29, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2023
@seshachalam-yv
Add serviceaccount component
4303c81 
- Remove serviceaccount from template yaml from chart
- Add unit tests for serviceaccount component
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Mar 29, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 29, 2023
@unmarshall unmarshall merged commit 03d2826 into gardener:master Mar 29, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 29, 2023
@seshachalam-yv seshachalam-yv deleted the feat/serviceaccount-component branch March 29, 2023 06:30
seshachalam-yv added a commit to seshachalam-yv/etcd-druid that referenced this pull request Apr 6, 2023
@seshachalam-yv
Add serviceaccount component (gardener#535)
ecb0a30 
- Remove serviceaccount from template yaml from chart
- Add unit tests for serviceaccount component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

@abdasgupta abdasgupta abdasgupta approved these changes

@aaronfern aaronfern aaronfern approved these changes

Assignees

@seshachalam-yv seshachalam-yv

Labels
area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@seshachalam-yv @abdasgupta @unmarshall @gardener-robot @aaronfern @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3