-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor
RoleBinding Helm charts into component (#539)
* Add rolebinding component - Add utils function `GetRoleBindingName` - Add unit tests for RoleBinding component * Remove RoleBinding from template yaml from chart * Addressed review feeback * Apply suggestions from code review Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com> * Revert the changes which are not related to this PR's scope. * Use Etcd Druid group from types_etcd GroupVersion.Group --------- Co-authored-by: Madhav Bhargava <madhav.bhargava@sap.com>
- Loading branch information
1 parent
ebc8311
commit fe0d4cf
Showing
10 changed files
with
434 additions
and
90 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| // Copyright (c) 2023 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package rolebinding | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
| "github.com/gardener/gardener/pkg/controllerutils" | ||
|
|
||
| gardenercomponent "github.com/gardener/gardener/pkg/operation/botanist/component" | ||
| rbacv1 "k8s.io/api/rbac/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| ) | ||
|
|
||
| type component struct { | ||
| client client.Client | ||
| values *Values | ||
| } | ||
|
|
||
| func (c component) Deploy(ctx context.Context) error { | ||
| roleBinding := c.emptyRoleBinding() | ||
| _, err := controllerutils.GetAndCreateOrStrategicMergePatch(ctx, c.client, roleBinding, func() error { | ||
| roleBinding.Name = c.values.Name | ||
| roleBinding.Namespace = c.values.Namespace | ||
| roleBinding.Labels = c.values.Labels | ||
| roleBinding.OwnerReferences = c.values.OwnerReferences | ||
| roleBinding.RoleRef = rbacv1.RoleRef{ | ||
| APIGroup: "rbac.authorization.k8s.io", | ||
| Kind: "Role", | ||
| Name: c.values.RoleName, | ||
| } | ||
| roleBinding.Subjects = []rbacv1.Subject{ | ||
| { | ||
| Kind: "ServiceAccount", | ||
| Name: c.values.ServiceAccountName, | ||
| Namespace: c.values.Namespace, | ||
| }, | ||
| } | ||
| return nil | ||
| }) | ||
| return err | ||
| } | ||
|
|
||
| func (c component) Destroy(ctx context.Context) error { | ||
| return client.IgnoreNotFound(c.client.Delete(ctx, c.emptyRoleBinding())) | ||
| } | ||
|
|
||
| func (c *component) emptyRoleBinding() *rbacv1.RoleBinding { | ||
| return &rbacv1.RoleBinding{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: c.values.Name, | ||
| Namespace: c.values.Namespace, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| // New creates a new role binding deployer instance. | ||
| func New(c client.Client, value *Values) gardenercomponent.Deployer { | ||
| return &component{ | ||
| client: c, | ||
| values: value, | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // Copyright (c) 2023 SAP SE or an SAP affiliate company. All rights reserved. This file is licensed under the Apache Software License, v. 2 except as noted otherwise in the LICENSE file | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package rolebinding | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| func TestRoleBinding(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
| RunSpecs(t, "RoleBinding Component Suite") | ||
| } |
Oops, something went wrong.