Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

[rel-v3.4.18] Build Multi-Arch Images 📦 #20

Closed
wants to merge 3 commits into from
Closed

[rel-v3.4.18] Build Multi-Arch Images 📦 #20

wants to merge 3 commits into from

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Jul 5, 2022 •
edited
Loading

What this PR does / why we need it:
This PR lets the CI pipeline build multi-arch images including linux/amd64 and linux/arm64 images.

Release note:

Published docker images for Etcd-Custom-Image are now multi-arch ready. They support `linux/amd64` and `linux/arm64`.

@timuthy timuthy added area/delivery Delivery related kind/enhancement Enhancement, improvement, extension labels Jul 5, 2022
@timuthy timuthy requested a review from a team as a code owner July 5, 2022 12:11
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jul 5, 2022
shreyas-s-rao
shreyas-s-rao approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 7, 2022
@shreyas-s-rao
Copy link
Contributor

@timuthy I think you might have to bump the VERSION in this PR, since we don't want the new image to overwrite the older one, do we?

@timuthy
Copy link
Member Author

timuthy commented Jul 12, 2022

Thanks for reminding me @shreyas-s-rao. Done ✅

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jan 8, 2023
@timuthy
Copy link
Member Author

timuthy commented May 12, 2023

I'm closing this PR as there is no activity to merge the changes. Feel free to open it again if required.
/close

@gardener-robot
Copy link

@timuthy Branch feature.arm64-support-etcd-3.4.18 has been deleted.

@gardener-robot gardener-robot deleted the feature.arm64-support-etcd-3.4.18 branch May 12, 2023 09:10
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees
No one assigned
Labels
area/delivery Delivery related kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timuthy @shreyas-s-rao @gardener-robot