Add support for OCS S3 snapstore #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoyanr
requested review from
georgekuruvillak,
shreyas-s-rao and
swapnilgm
as code owners
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
|
/cc @shreyas-s-rao |
|
/cc @rootfs |
rootfs
reviewed
Sep 24, 2020
rootfs
approved these changes
Sep 24, 2020
|
/lgtm |
|
@stoyanr Thanks a lot for the PR and the new provider support! We were held up with some landscape issues and review already this week. I apologize. |
|
/cc @shreyas-s-rao @amshuman-kr could you please take a look into this? Thanks! |
|
Hi @stoyanr. Thanks for your PR. Will review it today, since I was busy the past few days. |
amshuman-kr
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
@stoyanr Thanks a lot for the PR and sorry for the delay in the review! The PR looks good. Would it be possible for you to give access to an OCS environment for us to test before merging?
stoyanr
force-pushed
the
add-ocs-snapstore
branch
from
17d9939 to
bfce75c
Compare
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
shreyas-s-rao
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
@stoyanr Thanks for the PR and for refactoring the generic S3 snapstore. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds support for OpenShift Container Storage (OCS) S3-compatible snapstore. Also refactors the existing ECS snapstore to avoid code duplication since the 2 snapstores are quite similar.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
See also gardener/etcd-druid#98.
Release note: