Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick data verification optimization and defer initial full snapshot #157

Merged
merged 2 commits into from
May 8, 2019
Merged

Cherry pick data verification optimization and defer initial full snapshot #157

merged 2 commits into from
May 8, 2019

Conversation

shreyas-s-rao
Copy link
Collaborator

What this PR does / why we need it:
This PR is a cherry pick of #155 and #154

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Optimized WAL verification memory usage.

Updated etcd vendoring version to 3.3.13.

Full snapshot on etcd startup will now be deferred in favour of an initial delta snapshot, followed by a full snapshot and subsequent delta snapshots.

@shreyas-s-rao
Optimize wal verification
1ca7dc6 
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
@shreyas-s-rao
Defer first full snapshot on etcd startup
499b1f0 
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
@shreyas-s-rao shreyas-s-rao added kind/enhancement Enhancement, improvement, extension needs/review Needs review component/etcd-backup-restore ETCD Backup & Restore platform/all needs/lgtm Needs approval for merging area/backup Backup related area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 8, 2019
@shreyas-s-rao shreyas-s-rao added this to the 1904b milestone May 8, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 8, 2019
@swapnilgm swapnilgm merged commit fd435ac into gardener:rel-0.6.0 May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

@swapnilgm swapnilgm Awaiting requested review from swapnilgm

Assignees
No one assigned
Labels
area/backup Backup related area/performance Performance (across all domains, such as control plane, networking, storage, etc.) related component/etcd-backup-restore ETCD Backup & Restore kind/enhancement Enhancement, improvement, extension needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review platform/all reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Milestone
1904b
Development

Successfully merging this pull request may close these issues.
3 participants
@shreyas-s-rao @swapnilgm @gardener-robot-ci-1