Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick etcd readiness probe optimization and alpine version update #153

Merged
merged 2 commits into from
Apr 30, 2019
Merged

Cherry pick etcd readiness probe optimization and alpine version update #153

merged 2 commits into from
Apr 30, 2019

Conversation

shreyas-s-rao
Copy link
Collaborator

@shreyas-s-rao shreyas-s-rao commented Apr 30, 2019 •
edited
Loading

Signed-off-by: Shreyas Rao shreyas.sriganesh.rao@sap.com

What this PR does / why we need it:
This is a cherry-pick of #146 and #151

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Reduced etcd downtime by optimizing readiness probe.

Updated the base image of alpine in docker container to 3.9.3.

@shreyas-s-rao shreyas-s-rao added kind/enhancement Enhancement, improvement, extension reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) component/etcd-backup-restore ETCD Backup & Restore platform/all area/high-availability High availability related labels Apr 30, 2019
@shreyas-s-rao shreyas-s-rao added this to the 1904b milestone Apr 30, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 30, 2019
Swapnil Mhamane and others added 2 commits April 30, 2019 16:10
@shreyas-s-rao
Update the docker alpine base image.
73e12ab 
Signed-off-by: Swapnil Mhamane <swapnil.mhamane@sap.com>
@shreyas-s-rao
Optimize etcd readiness probe
42dacb5 
Signed-off-by: Shreyas Rao <shreyas.sriganesh.rao@sap.com>
@shreyas-s-rao shreyas-s-rao force-pushed the cherry-pick-readiness-probe-optimization branch from 0fca586 to 42dacb5 Compare April 30, 2019 10:41
@shreyas-s-rao shreyas-s-rao added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 30, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 30, 2019
@shreyas-s-rao shreyas-s-rao added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 30, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 30, 2019
@shreyas-s-rao shreyas-s-rao changed the title Cherry pick etcd readiness probe optimization Cherry pick etcd readiness probe optimization and alpine version update Apr 30, 2019
@shreyas-s-rao shreyas-s-rao merged commit 610a18c into gardener:rel-0.6.0 Apr 30, 2019
@shreyas-s-rao shreyas-s-rao deleted the cherry-pick-readiness-probe-optimization branch April 30, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

@swapnilgm swapnilgm Awaiting requested review from swapnilgm

Assignees
No one assigned
Labels
area/high-availability High availability related component/etcd-backup-restore ETCD Backup & Restore kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/all
Projects
None yet
Milestone
1904b
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyas-s-rao @gardener-robot-ci-1