Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip snap store specific sanity check when not configured #122

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Skip snap store specific sanity check when not configured #122

merged 1 commit into from
Feb 19, 2019

Conversation

swapnilgm
Copy link
Contributor

Signed-off-by: Swapnil Mhamane swapnil.mhamane@sap.com

What this PR does / why we need it:
Currently, for case like etcd-events where we don't configure storage provider to disable backups, the backup dependent sanity checks fails with panic. This PR fixes the issue.
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

In case of storage provider is not configured, i.e. backup disabled, we skip the backup dependent sanity checks.

@swapnilgm swapnilgm added kind/bug Bug priority/critical Needs to be resolved soon, because it impacts users negatively platform/all needs/lgtm Needs approval for merging area/backup Backup related needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 19, 2019
@swapnilgm swapnilgm added this to the 0.5.1 milestone Feb 19, 2019
@swapnilgm swapnilgm added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 19, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 19, 2019
Skip snap store specific sanity check when not configured
3fdf4dd 
Signed-off-by: Swapnil Mhamane <swapnil.mhamane@sap.com>
@swapnilgm swapnilgm force-pushed the fix/skip-db-specific-sanity-checks branch from 1936d5a to 3fdf4dd Compare February 19, 2019 12:34
@swapnilgm swapnilgm added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 19, 2019
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 19, 2019
@swapnilgm swapnilgm mentioned this pull request Feb 19, 2019
Merged
@swapnilgm swapnilgm merged commit b7d9902 into gardener:master Feb 19, 2019
@swapnilgm swapnilgm deleted the fix/skip-db-specific-sanity-checks branch February 19, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgekuruvillak georgekuruvillak Awaiting requested review from georgekuruvillak

@shreyas-s-rao shreyas-s-rao Awaiting requested review from shreyas-s-rao

Assignees
No one assigned
Labels
area/backup Backup related kind/bug Bug needs/lgtm Needs approval for merging needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/all priority/critical Needs to be resolved soon, because it impacts users negatively
Projects
None yet
Milestone
0.5.1
Development

Successfully merging this pull request may close these issues.
2 participants
@swapnilgm @gardener-robot-ci-1