Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Getting Started section - Images #467

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Update Getting Started section - Images #467

merged 5 commits into from
Jan 24, 2024

Conversation

n-boshnakov
Copy link
Contributor

@n-boshnakov n-boshnakov commented Jan 23, 2024 •
edited
Loading

What this PR does / why we need it:
This PR updates the Getting Started section:

  • changed colors in some images to SAP approved ones
  • updated images for clarity
  • added content to some topics
  • updated order of topics for better flow

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@n-boshnakov n-boshnakov requested a review from a team as a code owner January 23, 2024 15:34
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 23, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 24, 2024
hendrikKahl
hendrikKahl approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@hendrikKahl hendrikKahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 24, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 24, 2024
JordanJordanov
JordanJordanov approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@JordanJordanov JordanJordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jessica-Katz
Copy link
Contributor

🎉 Thanks a lot for addressing the feedback! The colors are much more consistent now, and I'm really pleased with the improvement. Great work! 👍

@n-boshnakov n-boshnakov merged commit 727a56c into gardener:master Jan 24, 2024
3 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikKahl hendrikKahl hendrikKahl approved these changes

@JordanJordanov JordanJordanov JordanJordanov approved these changes

@MrBatschner MrBatschner Awaiting requested review from MrBatschner

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@n-boshnakov @Jessica-Katz @JordanJordanov @hendrikKahl @gardener-robot-ci-3 @gardener-robot