Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added relative link guideline & restructured Formatting Guide #401

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Added relative link guideline & restructured Formatting Guide #401

merged 1 commit into from
Mar 17, 2023

Conversation

n-boshnakov
Copy link
Contributor

What this PR does / why we need it:
This PR:

  • adds a guideline for using relative link in the documentation
  • restructures the Formatting Guide to bring the API Objects and Technical Components section to the front
  • fixes broken relative links and updates capitalization

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

NONE

@n-boshnakov n-boshnakov requested a review from a team as a code owner March 15, 2023 13:44
@gardener-robot gardener-robot added the needs/review Needs review label Mar 15, 2023
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Mar 15, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Mar 15, 2023
JordanJordanov
JordanJordanov approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@JordanJordanov JordanJordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@n-boshnakov n-boshnakov merged commit 66e22e4 into gardener:master Mar 17, 2023
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Mar 17, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Mar 17, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanJordanov JordanJordanov JordanJordanov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n-boshnakov @JordanJordanov @gardener-robot-ci-2 @gardener-robot