Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cert-management tutorials for Gardener. #30

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Nov 20, 2018

This PR adds an operator as well as an app-developer tutorial for certificate management via Gardener.

@timuthy timuthy requested a review from a team as a code owner November 20, 2018 09:08
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions!

@timuthy timuthy force-pushed the feature/cert-management branch from b66d5b3 to 2a2396b Compare November 20, 2018 11:52
@timuthy
Copy link
Member Author

timuthy commented Nov 20, 2018

Thanks @rfranzke, PTAL.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, minor things

@timuthy timuthy force-pushed the feature/cert-management branch from 2a2396b to 2659135 Compare November 21, 2018 07:20
@freegroup
Copy link
Contributor

freegroup commented Nov 21, 2018

"example/10-secret-certificate-management-config.yaml" isn't a link....I will change this

@freegroup
Copy link
Contributor

where is the file "/dev/20-componentconfig-gardener-controller-manager.yaml" located?

@freegroup freegroup merged commit afba8be into gardener:master Nov 21, 2018
@timuthy
Copy link
Member Author

timuthy commented Nov 23, 2018

Thanks @freegroup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants