Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DNS guide for devs #119

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Update DNS guide for devs #119

merged 1 commit into from
Aug 19, 2020

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Jul 31, 2020

What this PR does / why we need it:
This PR updates and extends the DNS guide for end users.
Release note:

Information about Gardener's DNS management for shoot clusters has been updated.

@timuthy timuthy requested a review from a team as a code owner July 31, 2020 15:19
@timuthy
Copy link
Member Author

timuthy commented Aug 3, 2020

/invite @MartinWeindel

@gardener-robot gardener-robot added the needs/review Needs review label Aug 3, 2020
@timuthy
Copy link
Member Author

timuthy commented Aug 19, 2020

@MartinWeindel do you want to take a look?

MartinWeindel
MartinWeindel approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@MartinWeindel MartinWeindel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Aug 19, 2020
@timuthy timuthy merged commit a8d2c2b into gardener:master Aug 19, 2020
@timuthy timuthy deleted the update.dns branch August 19, 2020 13:27
@g-pavlov g-pavlov mentioned this pull request Aug 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinWeindel MartinWeindel MartinWeindel approved these changes

Assignees
No one assigned
Labels
reviewed/lgtm Has approval for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timuthy @MartinWeindel @gardener-robot