Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DWD prober to check Node Leases #94

Merged
merged 16 commits into from
Feb 6, 2024

Conversation

rishabh-11
Copy link
Collaborator

@rishabh-11 rishabh-11 commented Dec 13, 2023

What this PR does / why we need it:
This PR removes the old logic of DWD prober doing two probes, internal and external. The internal probe still happens and is renamed to APIServerProbe, and a NodeLease probe is introduced, which replaces the external probe. It takes a look at the number of expired Node Leases and performs a scale-down if the threshold is crossed. Refer #85 to see why this is required.

Which issue(s) this PR fixes:
Fixes #85

Special notes for your reviewer:

Release note:

DWD no longer depends on checking the reachability of Kube-API server via external load-balancer as kube-proxy path optimizations makes that impossible on infrastructures which have a static IP for the LB. Instead it now depends on node leases that are periodically renewed by each node running in the shoot cluster to determine its scaling action (scale-down/up).

Copy link

gardener-prow bot commented Dec 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 13, 2023
@rishabh-11 rishabh-11 changed the title Change DWD prober to use Node Leases Change DWD prober to check Node Leases Dec 13, 2023
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2023
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2023
@rishabh-11 rishabh-11 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2024
@rishabh-11 rishabh-11 marked this pull request as ready for review January 2, 2024 06:56
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 2, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2024
@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels Jan 2, 2024
@rishabh-11 rishabh-11 added the kind/api-change API change with impact on API users label Jan 2, 2024
@gardener-prow gardener-prow bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jan 2, 2024
@rishabh-11
Copy link
Collaborator Author

The testing of this PR was done on AWS and GCP. Attaching files for AWS and GCP logs, DWD config map and rootboy.txt (used for shutting down kubelet) :-

AWS.md
GCP.md
dwd-cm.txt
rootboy.txt

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
Copy link

gardener-prow bot commented Feb 6, 2024

LGTM label has been added.

Git tree hash: d8bf7eae8c15af6cae090bc7da92d8719f471b8e

Copy link

gardener-prow bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: unmarshall

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2024
@gardener-prow gardener-prow bot merged commit 55cc369 into gardener:master Feb 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/api-change API change with impact on API users lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
8 participants