-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change DWD prober to check Node Leases #94
Conversation
Skipping CI for Draft Pull Request. |
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
The testing of this PR was done on AWS and GCP. Attaching files for AWS and GCP logs, DWD config map and rootboy.txt (used for shutting down kubelet) :- |
…rce infos to scaler instead of probe config
LGTM label has been added. Git tree hash: d8bf7eae8c15af6cae090bc7da92d8719f471b8e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: unmarshall The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR removes the old logic of DWD prober doing two probes, internal and external. The internal probe still happens and is renamed to APIServerProbe, and a NodeLease probe is introduced, which replaces the external probe. It takes a look at the number of expired Node Leases and performs a scale-down if the threshold is crossed. Refer #85 to see why this is required.
Which issue(s) this PR fixes:
Fixes #85
Special notes for your reviewer:
Release note: