Skip to content

allow to update certificate secrets with type kubernetes.io/tls #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

MartinWeindel
Copy link
Member

What this PR does / why we need it:
Existing TLS secret for an ingress may have type kubernetes.io/tls and updating
the secret fails, as cert-manage uses type Opaque by default.

Which issue(s) this PR fixes:
Fixes #8

Release note:

Existing certificate secrets with type `kubernetes.io/tls` can be updated
to simplify migration from cert-broker/cert-manager.

@MartinWeindel MartinWeindel requested a review from a team as a code owner November 19, 2019 14:51
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 19, 2019
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 19, 2019
@MartinWeindel MartinWeindel merged commit af52e60 into master Nov 19, 2019
@MartinWeindel MartinWeindel deleted the fix-issue8 branch November 19, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating certificate secrets with type kubernetes.io/tls fails
3 participants