[ACME] Fix account registration on issuer secret update #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update of the account registration in the issuer status is not handled correctly if the issuer secret of type
ACME
is updated.Besides, the default behaviour is unsuitable for secret rotation, as it triggers an immediate renewal of all certificates.
To allow secret rotation without immediate renewals, all certificate secret hashes are migrated. The new hash includes the issuer key instead of the issuer secret.
Additionally the error handling has been harmonised by replacing
Wrap´ from
github.com/pkg/errorswith
fmt.Errorf("...: %w", err)`Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: