[ACME] Fix account registration on issuer secret update #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
needs/review
gardener-robot-ci-1
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
fix-replace-issuer-secret
branch
from
acd6e80
to
e54fc18
Compare
gardener-robot
added
size/L
gardener-robot-ci-2
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
fix-replace-issuer-secret
branch
from
e54fc18
to
6cd5451
Compare
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
MartinWeindel
force-pushed
the
fix-replace-issuer-secret
branch
from
6cd5451
to
fd4ea29
Compare
gardener-robot-ci-1
added
reviewed/ok-to-test
MartinWeindel
force-pushed
the
fix-replace-issuer-secret
branch
from
fd4ea29
to
67ba76e
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
…, migrate certificate hash, stop using pkg/errors
MartinWeindel
force-pushed
the
fix-replace-issuer-secret
branch
from
67ba76e
to
1fc8b05
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update of the account registration in the issuer status is not handled correctly if the issuer secret of type
ACMEis updated.Besides, the default behaviour is unsuitable for secret rotation, as it triggers an immediate renewal of all certificates.
To allow secret rotation without immediate renewals, all certificate secret hashes are migrated. The new hash includes the issuer key instead of the issuer secret.
Additionally the error handling has been harmonised by replacing
Wrap´ fromgithub.com/pkg/errorswithfmt.Errorf("...: %w", err)`Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: